Remove statics libs not needed after the build #9
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I imagine this is okay, but it probably needs to be tested to ensure it doesn't break anything. Have you been able to do that? |
smortex
approved these changes
May 28, 2025
There was a problem hiding this comment.
This look reasonable. Working on #19 I did not had differences in these files anymore, but as they are not useful we can probably strip them from the generated artifact, and so in the end from the AIO package.
Maybe we can go further with removing unneeded bits from the AIO package, e.g. the hundreds of man pages of curl.
|
As it turns out, this broke Windows builds :( |
smortex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statics libs are keep in the build and are not necessary after it. As the .a archive format contain headers informations like the time when they are made, it broke the possibility to have reproducible build.