Add Makefile rules to create a release tarball#92
Draft
ekohl wants to merge 1 commit intoOpenVoxProject:mainfrom
Draft
Add Makefile rules to create a release tarball#92ekohl wants to merge 1 commit intoOpenVoxProject:mainfrom
ekohl wants to merge 1 commit intoOpenVoxProject:mainfrom
Conversation
ekohl
commented
Aug 27, 2025
Contributor
Author
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I also think we should drop all the sysvinit stuff and clean up a lot more before we merge this.
Comment on lines
+117
to
+122
| # bash will eat your spaces, so let's array. see http://mywiki.wooledge.org/BashFAQ/050 for more fun. | ||
| params=("--user" "puppet" "--group" "puppet" "--chdir" "$dir" "--realname" "puppetserver" "--operating-system" "$os" "--name" "openvox-server" "--package-version" "8.11.0" "--release" "1" "--platform-version" "8") | ||
| if [ -n "$os_version" ]; then params+=("--os-version" "$os_version"); fi | ||
| if [ -n "$os_dist" ]; then params+=("--dist" "$os_dist"); fi | ||
|
|
||
| params+=('--description' "$(printf "Vox Pupuli puppetserver\nContains: OpenVox Server (puppetlabs/puppetserver 8.11.0,org.clojure/clojure 1.11.2,org.bouncycastle/bcpkix-jdk18on 1.78.1,puppetlabs/jruby-utils 5.2.0,puppetlabs/puppetserver 8.11.0,com.puppetlabs/trapperkeeper-webserver-jetty10 1.0.18,puppetlabs/trapperkeeper-metrics 2.0.4)")") |
Contributor
Author
There was a problem hiding this comment.
I think this part should be templated somehow
Comment on lines
+126
to
+146
| params+=('--replaces' "'puppetserver',''") | ||
|
|
||
|
|
||
| params+=('--create-dir' '/opt/puppetlabs/server/data/puppetserver/jars') | ||
| params+=('--create-dir' '/opt/puppetlabs/server/data/puppetserver/yaml') | ||
|
|
||
|
|
||
|
|
||
| if [[ "$os" = 'el' || "$os" = 'sles' || "$os" = 'fedora' || "$os" = 'redhatfips' || "$os" = 'amazon' ]]; then | ||
| # pull in rpm dependencies | ||
| params+=("--additional-dependency") | ||
| params+=("openvox-agent >= 8.21.1") | ||
| # get rpm install trigger scripts | ||
| # get rpm upgrade trigger scripts | ||
| : # Need something in case there are no additional dependencies | ||
| else | ||
| # if we aren't an rpm, pull in deb dependencies | ||
| params+=("--additional-dependency") | ||
| params+=("openvox-agent (>= 8.21.1)") | ||
| : # Need something in case there are no additional dependencies | ||
| fi |
Contributor
Author
There was a problem hiding this comment.
This part can probably be folded into fpm.rb.
Contributor
Author
There was a problem hiding this comment.
I don't think this file is really needed in the tarball
Contributor
Author
There was a problem hiding this comment.
I don't know why this file is here, but it's in the tarball now.
Comment on lines
+146
to
+147
| install -d "${DESTDIR}${app_prefix}/share/doc/puppetserver-8.11.0" | ||
| cp -a ext/docs "${DESTDIR}${app_prefix}/share/doc/puppetserver-8.11.0" |
Contributor
Author
There was a problem hiding this comment.
Here it also has the version number so some templating. Though I'm not sure if the docs code path is really used.
Contributor
Author
There was a problem hiding this comment.
This also should be generated somehow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is something we discussed earlier. It is an attempt to get rid of ezbake.
The idea is that you run
make distto create the release tarball. This can then be consumed by packaging to build the various RPMs and Debian packages.For now I just took the files from the openvox-server 8.11.0 release tarball and added it together with a
Makefile. That produces a tarball.However, this isn't consumed by packaging now and not hooked into CI and release flows. I don't know how to do that well, but this is the start.