Add: GStreamer testing for ancillary #1251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DawidWesierski4
force-pushed
the
fix_meta_st40
branch
from
8989195 to
5a2dd4c
Compare
Falron98
requested changes
Aug 29, 2025
DawidWesierski4
changed the title
DawidWesierski4
force-pushed
the
fix_meta_st40
branch
from
5a2dd4c to
6d733d4
Compare
Sakoram
reviewed
Aug 29, 2025
Sakoram
reviewed
Aug 29, 2025
DawidWesierski4
force-pushed
the
fix_meta_st40
branch
5 times, most recently
from
0708d60 to
2928017
Compare
We process the meta_num incorrectly in st40_pipeline_tx.c, leading to potential issues with frame metadata handling. Fix it by overwriting the anc_frame meta_num and treating the framebuff from pipeline anc size as the only source of truth. Fix the inproper handling of the CAPS negotiation signal, for now just ignore consecutive signals TODO: Checking and reinitialization of the session. Add the ability for the st40 gstreamer plugin to parse multiple ancillary packages, including support for different payload types and dynamic reconfiguration. Add the ability for st20 video plugin to work without metadata with assumed bit configuration. Add the st40p meta insertion into the metadata element Test the changes by adding the ability for the pytest framework to generate data from both the Rx simplified rfc8331 and the Tx rfc8331 custom formats (ancgenerator) For more advanced anc frames testing. Add the ability for the testing framework in gstreamer to run user pacing scanrios TODO: Add tests for user pacing TODO: Add lipsync for gstreamer Fix: fix the way we handle killing and signal handling in gstreamer engine. Fix: error reporting for paths in testing framework For easier debugging and maintenance. reverts: fc4c95a
DawidWesierski4
force-pushed
the
fix_meta_st40
branch
8 times, most recently
from
31e8344 to
0530c54
Compare
DawidWesierski4
force-pushed
the
fix_meta_st40
branch
from
f9cc158 to
b7da49a
Compare
Sakoram
reviewed
Sep 4, 2025
Sakoram
reviewed
Sep 4, 2025
DawidWesierski4
force-pushed
the
fix_meta_st40
branch
4 times, most recently
from
0aa7a68 to
44018cd
Compare
Sakoram
reviewed
Sep 8, 2025
Sakoram
reviewed
Sep 8, 2025
Co-authored-by: Marek Kasiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We process the meta_num incorrectly in
st40_pipeline_tx.c, leading to potential issues
with frame metadata handling.
Fix it by overwriting the anc_frame meta_num and
treating the framebuff from pipeline anc size
as the only source of truth.
Fix the improper handling of the CAPS negotiation
signal, for now, just ignore consecutive signals
TODO: Checking and reinitialization of the session.
Add the ability for the ST40 GStreamer plugin to
parse multiple ancillary packages, including
support for different payload types and
dynamic reconfiguration.
Add the ability for st20 video plugin to work
without metadata with an assumed bit configuration.
Add the st40p meta insertion into the metadata
element
Test the changes by adding the ability for the
pytest framework to generate data from both the
Rx simplified rfc8331 and the Tx rfc8331
custom formats (ancgenerator)
For more advanced anc frames testing.
Add the ability for the testing framework in
GStreamer to run user pacing scenarios
TODO: Add tests for user pacing
TODO: Add lipsync for GStreamer
TODO: Add redundant scenarios
Fix the way we handle killing and signal
handling in the GStreamer engine.
Fix unlocked the st40 pipeline abilility to use anc_count == 0
To test: the pr the GStreamer tools and plugins need
to be compiled
$ meson setup builddir
$ ninja -C build
Fixes: dd61100