-
Notifications
You must be signed in to change notification settings - Fork 72
Test: Automation for netsniff-ng packet capture #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Change test cases names; Adjust logging;
…bug and FIXME comment
…instead of all traffic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds automation support for netsniff-ng packet capture alongside existing tcpdump functionality, allowing test configuration to choose between capture tools via a tool
parameter. The implementation includes a new NetsniffRecorder class modeled after TcpDumpRecorder and updates test files to support both capture methods.
- Introduces conditional packet capture execution for netsniff-ng across test execution engines
- Adds NetsniffRecorder class for netsniff-ng packet capture automation
- Updates comment consistency to reflect actual configuration behavior rather than just tcpdump
Reviewed Changes
Copilot reviewed 52 out of 53 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
tests/validation/configs/test_config.yaml | Adds tool configuration option for capture method selection |
tests/validation/create_pcap_file/netsniff.py | New NetsniffRecorder class implementation for netsniff-ng automation |
tests/validation/mtl_engine/RxTxApp.py | Adds netsniff support and fixes dual test interface configuration |
tests/validation/mtl_engine/ffmpeg_app.py | Integrates netsniff capture in ffmpeg tests and adds new dual test functions |
tests/validation/mtl_engine/GstreamerApp.py | Adds netsniff capture support to GStreamer tests |
tests/validation/mtl_engine/udp_app.py | Integrates netsniff capture in UDP application tests |
Multiple test files | Updates comments to reflect packet capture configuration rather than tcpdump-specific |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
75f6394
to
01bad5b
Compare
a77c7bd
to
cb29b49
Compare
cb29b49
to
48bec15
Compare
…rge conflict resolution
…are to be fully moved to a fixture
Merge only after #1236 and #1234.
Adds automation capabilities for netsniff-ng packet capture instead of tcpdump. As both should not be executed at once, such option was not added.
tests/validation/configs/test_config.yaml
addedtool
in.capture_cfg
with following options recognized:tcpdump
fortcpdump
,netsniff
ornetsniff-ng
fornetsniff-ng
tests/validation/create_pcap_file/netsniff.py
createdNetsniffRecorder
class based onTcpDumpRecorder
that can serve asnetsniff-ng
capturing process classnetsniff-ng
packet capture intests/validation/mtl_engine/GstreamerApp.py
,tests/validation/mtl_engine/ffmpeg_app.py
tests/validation/mtl_engine/udp_app.py
TODO:
Postponed for further reconsideration due to priority:
test_name
generation*code-less here means without interfering with the test code