Basic GUI Variables set up and piped for Politics Menu #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hop311
reviewed
Feb 6, 2025
game/src/Game/GameSession/NationManagementScreen/PoliticsMenu.gd
Outdated
Show resolved
Hide resolved
game/src/Game/GameSession/NationManagementScreen/PoliticsMenu.gd
Outdated
Show resolved
Hide resolved
Hop311
reviewed
Feb 7, 2025
game/src/Game/GameSession/NationManagementScreen/PoliticsMenu.gd
Outdated
Show resolved
Hide resolved
game/src/Game/GameSession/NationManagementScreen/PoliticsMenu.gd
Outdated
Show resolved
Hide resolved
Hop311
approved these changes
Feb 8, 2025
Fixed piping functions Update game/src/Game/GameSession/NationManagementScreen/PoliticsMenu.gd Co-authored-by: Hop311 <[email protected]> Update game/src/Game/GameSession/NationManagementScreen/PoliticsMenu.gd Co-authored-by: Hop311 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all the basic GUI variables and got them piped from the .gui file. Also includes placeholder functions for all added buttons.
Note:
This does not include more complex listbox/panel entries such as
-Ideology Option
-Issue Option
-Reform Option
-Decision Entry
-Rebel Entry
-Party Window
-Select New Party
-Party Issue Option
-Release Nation Entry
-Movement Entry
I didn't know how to handle these, some of these may be better served being sub classes, especially those that are listbox entries.
Also didn't have time to test building it so if it breaks, oops