Authomatic (auth/login), Pyramid-friend comments, misc fixes #1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As usual, we capture high-level intent in requirements.in, then freeze the as-built versions in requirements.txt. See pipdeptree.out for a full explanation of module dependencies.
NB - This now includes some modules from the *internal* requirements from synthetic_tree_viewer/setup.py [testing]
This lists details like API method URLs, vs. the main Pyramid config file. Adapted from the old web2py app.
NB - This might not be needed after all, if get_conf is supported in all page templates.
NB - We'll keep the existing URL pattern, rather than simplifying it, to support links saved previously.
This is syntactically correct, but needs testing in a proper CGI environment to be sure.
This also requires cleanup and standardized calls for an authenticated user, or substitutes for anonymous commenters.
Required to pre-compile nested comment threads before we render to a Jinja2 template.
Includes correct assignment of logged-in vs. visitor info.
Traditionally, datetime objects have often been "naive" with no sense of time zone. Recent versions of Python 3 encourage making time zones explicit to avoid problems.
The subrequest that brings local comments should also respect the URL of the original (main) request and repeat. This is not working! :-/
This is required for Github auth and APIs
It won't help the webapp load comments at the target synthtree+nodeid, but it's handy for users to back-track from a Github issue to the original page.
This persists across the subrequest w/o being mangled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a ton of recent work, finally being merged back to the default branch. Onward!