Fix: Swapped handling of high bit depth and extra zoom in nml preprocessing#242
Merged
Fix: Swapped handling of high bit depth and extra zoom in nml preprocessing#242
Conversation
…essing The preprocessor was retaining 32bpp images when 4x zoom was requested, and 4x zoom when 32bpp images were requested. Not a problem for building the current variants (1x 8bpp, 4x 32bpp) because it was 'all or nothing', but caused the wrong variant to be generated if 1x 32bpp or 4x 8bpp was requested.
LordAro
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
grfbuild pipeline uses preprocessing ofnmlfiles to remove or retain lines marked with combinations of#32and#ezas requested, to makenmlvariants which include 32bpp and 4x extra zoom sprites when wanted.The preprocessor was retaining 32bpp images when 4x zoom was requested, and 4x zoom when 32bpp images were requested. Not a problem for building the current variants (1x 8bpp Classic, 4x 32bpp High Def) because it was 'all or nothing', but caused the
nmlfor the wrong variant to be generated if 1x 32bpp or 4x 8bpp was requested.