Fix: Make sea level locks aware of neighbouring canals#238
Open
Fix: Make sea level locks aware of neighbouring canals#238
Conversation
zephyris
force-pushed
the
fix-237-sea-level-lock
branch
2 times, most recently
from
b2c80f2 to
14a1561
Compare
zephyris
force-pushed
the
fix-237-sea-level-lock
branch
from
14a1561 to
372dd61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canal locks checked for elevation, to use alternate graphics with mini-lighthouses and breaking waves when at sea level. This looked odd when building locks on sea level land.
Therefore, add a
canal_dikecheck, to check if canal walls would be built for that tile as a half-decent proxy for checking for neighbouring land tiles. Compare the top two locks in the example image.(mostly) Fixes #237
Corner cases are when the lock is surrounded by sea level locks or rivers. Com[are the bottom two locks in the example image.