Fix ShapeType initialization crash - #975
Merged
Merged
Conversation
Kyle-Ye
marked this pull request as ready for review
August 2, 2026 19:52
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
===========================================
- Coverage 27.30% 14.88% -12.42%
===========================================
Files 730 688 -42
Lines 53134 46885 -6249
===========================================
- Hits 14506 6977 -7529
- Misses 38628 39908 +1280 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CALayerorCAShapeLayerfor supported solid-color shapes.Root cause
ShapeType.initand the related shape-layer visitor helpers still called the unimplemented failure path, causing basic shape rendering and clipping to crash.Impact
Basic rectangles, circular and rounded shapes, and supported stroked paths can now be represented by shape layers instead of terminating during rendering.
Validation
Lightweight diff validation passed. The UI test suite was not run locally.