Add benchmark for simplify to runtests.jl #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ufechner7
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive benchmarking for the simplify function and removes deprecated TestEnv fallback code across test files. The benchmark is integrated into the main test suite with performance monitoring and cross-platform compatibility.
- Adds
bench_simplify.jlto production build tests inruntests.jl - Implements performance benchmarking with platform-specific adjustments and Julia version considerations
- Removes TestEnv activation code from multiple test files, relying on proper project test environment setup
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/runtests.jl | Adds bench_simplify.jl to production build test suite |
| test/bench_simplify.jl | Major refactor with subprocess benchmarking, performance reporting, and cross-platform adjustments |
| test/test_kps4.jl | Removes TestEnv activation fallback |
| test/test_kps3_fails.jl | Removes TestEnv activation with explanatory comment |
| test/plot_kps4.jl | Removes TestEnv fallback with explanatory comment |
| test/plot_kps3.jl | Removes TestEnv fallback with explanatory comment |
| test/create_sys_image.jl | Removes TestEnv activation line |
| test/bench4.jl | Removes TestEnv activation with explanatory comment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1-Bart-1
reviewed
Sep 29, 2025
| if ! ("Test" ∈ keys(Pkg.project().dependencies)) | ||
| using TestEnv; TestEnv.activate() | ||
| end | ||
| # Removed TestEnv activation; assume the test target environment is active. |
There was a problem hiding this comment.
why remove this? nice if you want to run the test separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.