Skip to content

Conversation

@luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom commented Oct 6, 2025

Closes #3106
See OpenSlides/openslides-meta#330

Info for client devs:

  1. This PR removes the motion.support_self action, use motion_submitter.create and motion_submitter.delete from now on
  2. Adding a meeting_user id-list for supporter_meeting_user_ids in motion.create will still create supporters
  3. There is no longer a possibility to edit supporters with motion.update, use motion_submitter.create and motion_submitter.delete
  4. Take note that the new permission rules for motion_submitter.create and motion_submitter.delete differ slightly from how it was with the previous system due to the fact that the permission requirements were merged together (see docs for rules)

@luisa-beerboom luisa-beerboom added this to the 4.3 milestone Oct 6, 2025
@luisa-beerboom luisa-beerboom self-assigned this Oct 6, 2025
@luisa-beerboom luisa-beerboom added migration Introduces a new migration enhancement General enhancement which is neither bug nor feature Schrödinger projectname labels Oct 6, 2025
@luisa-beerboom luisa-beerboom marked this pull request as ready for review October 7, 2025 14:48
@luisa-beerboom luisa-beerboom requested a review from hjanott October 7, 2025 14:48
@luisa-beerboom luisa-beerboom removed their assignment Oct 7, 2025
@luisa-beerboom luisa-beerboom removed the request for review from hjanott October 7, 2025 14:57
Copy link
Member

@hjanott hjanott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some questions and things to improve.

}

def test_meeting_support_system_deactivated(self) -> None:
def create_delegator_test_data(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you moved this file from motion/test_set_support_self.py. Or is this a github glitch? Will this lead to any complications when integrating this change into rel-db? Especially considering the current changes mixing with the rel-db ones? https://github.com/OpenSlides/openslides-backend/pull/3085/files#diff-3cd46c8071338c282fc2d1f68ac564beeab783c63c3b820b37b35f9881978b25

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to split the test_set_support_self tests between this and the create action test. Idk about how github's going to treat this in relation to relDB, though I guess it may have to be changed for it

@Elblinator Elblinator assigned luisa-beerboom and unassigned hjanott Oct 27, 2025
Copy link
Member

@hjanott hjanott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts.

@hjanott hjanott assigned luisa-beerboom and unassigned hjanott Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement General enhancement which is neither bug nor feature migration Introduces a new migration Schrödinger projectname

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add reference for deleted accounts in supporters

3 participants