-
Notifications
You must be signed in to change notification settings - Fork 32
Implement motion_supporter model #3173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement motion_supporter model #3173
Conversation
hjanott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some questions and things to improve.
| } | ||
|
|
||
| def test_meeting_support_system_deactivated(self) -> None: | ||
| def create_delegator_test_data( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you moved this file from motion/test_set_support_self.py. Or is this a github glitch? Will this lead to any complications when integrating this change into rel-db? Especially considering the current changes mixing with the rel-db ones? https://github.com/OpenSlides/openslides-backend/pull/3085/files#diff-3cd46c8071338c282fc2d1f68ac564beeab783c63c3b820b37b35f9881978b25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to split the test_set_support_self tests between this and the create action test. Idk about how github's going to treat this in relation to relDB, though I guess it may have to be changed for it
openslides_backend/migrations/migrations/0070_new_motion_supporter_model.py
Show resolved
Hide resolved
hjanott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts.
Closes #3106
See OpenSlides/openslides-meta#330
Info for client devs:
motion.support_selfaction, usemotion_submitter.createandmotion_submitter.deletefrom now onsupporter_meeting_user_idsinmotion.createwill still create supportersmotion.update, usemotion_submitter.createandmotion_submitter.deletemotion_submitter.createandmotion_submitter.deletediffer slightly from how it was with the previous system due to the fact that the permission requirements were merged together (see docs for rules)