docs(adr): renumber the auth idField ADR to 0071 to resolve a 0070 collision - #1555
Merged
Merged
Conversation
…llision 0070-the-auth-plugins-id-strategy-is-config-not-a-hardcoded-pin.md (#1550) and 0070-the-generated-clients-identity-is-a-process-wide-registry-entry.md (#1548) landed within a minute of each other and both claimed 0070, tripping check:adr-duplicates on every PR against main. Renumbered the id-strategy ADR to 0071 (2 filename-link updates in ADR-0048 and ADR-0060) rather than the client-identity one, which has 7+ scattered bare "(ADR-0070)" comment references across packages/core, packages/cli and packages/auth that would otherwise need updating instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HEEWCWcKXFFYY3PXE2zBH6
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks
Contributor
Coverage Report for Core Package Coverage (./packages/core)
File CoverageNo changed files found. |
Contributor
Coverage Report for UI Package Coverage (./packages/ui)
File CoverageNo changed files found. |
Contributor
Coverage Report for CLI Package Coverage (./packages/cli)
File CoverageNo changed files found. |
Contributor
Coverage Report for Auth Package Coverage (./packages/auth)
File CoverageNo changed files found. |
Contributor
Coverage Report for Storage Package Coverage (./packages/storage)
File CoverageNo changed files found. |
Contributor
Coverage Report for RAG Package Coverage (./packages/rag)
File CoverageNo changed files found. |
Contributor
Coverage Report for Storage S3 Package Coverage (./packages/storage-s3)
File CoverageNo changed files found. |
Contributor
Coverage Report for Storage Vercel Package Coverage (./packages/storage-vercel)
File CoverageNo changed files found. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main'scheck:adr-duplicates(pnpm check:adr-duplicates, run in thetestjob of every PR) currently fails onmainitself:0070-the-auth-plugins-id-strategy-is-config-not-a-hardcoded-pin.md(#1550) and0070-the-generated-clients-identity-is-a-process-wide-registry-entry.md(#1548) merged within a minute of each other and both claimed0070, so this is blocking thetestcheck on every open PR againstmain(discovered while driving #1554 to green).0070-the-auth-plugins-id-strategy-is-config-not-a-hardcoded-pin.md→0071-..., and updated its two filename-link references (indocs/adr/0048-...mdanddocs/adr/0060-...md).0070-the-generated-clients-identity-is-a-process-wide-registry-entry.mdat0070: it has 7+ scattered bare(ADR-0070)comment references acrosspackages/core,packages/cliandpackages/auththat would need updating instead, versus the 2 filename-link references the renamed file has.No package code changed — docs/ADR only, so no changeset.
Test plan
pnpm check:adr-duplicatespasses (71 numbers checked, no duplicates)cd docs && npx tsx scripts/link-check.tspasses (internal links still resolve)pnpm lint,pnpm formatcleangrepthat no other file references the renamed file's old path, and that every(ADR-0070)comment left untouched genuinely refers to the client-identity ADR that keeps the number 0070🤖 Generated with Claude Code
https://claude.ai/code/session_01HEEWCWcKXFFYY3PXE2zBH6
Generated by Claude Code