SAST checks #2258
Open
SAST checks #2258
+29
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 30, 2025 12:26
After having been compared to a NULL value, pointer 'scur->protocol' is dereferenced by calling function 'strcat'. Make return if getservbyname return 0, so we won't reach the strcpy call. Signed-off-by: smarchenkov <[email protected]>
Pointer 'packet' is passed to a free function at seap-packet.c:51 by passing as 1st parameter to function 'SEAP_packet_free' at seap.c:220 after the referenced memory was deallocated at seap-packet.c:51 by passing as 1st parameter to function 'SEAP_packet_free' at seap.c:220. Note: the second deallocation is on another loop iteration. Signed-off-by: smarchenkov <[email protected]>
Check for NULL pointer 'fp' returned from function 'fopen' Signed-off-by: smarchenkov <[email protected]>
Signed-off-by: smarchenkov <[email protected]>
evgenyz
requested changes
Sep 29, 2025
| { | ||
| free(packet); | ||
| if (packet != NULL) { | ||
| free(packet); |
| fp = fopen("/proc/net/ipv6_route", "r"); | ||
| if (fp == NULL) { | ||
| if (errno == ENOENT) { | ||
| dI("/proc/net/route does not exist. No IPv4 routing table available."); |
| if (service == NULL) { | ||
| return -1; | ||
| } | ||
| else { |
| dD("port not set, trying to guess from /etc/services for %s", scur->name); | ||
| if (service != NULL) { | ||
| if (service == NULL) { | ||
| return -1; |
There was a problem hiding this comment.
Also this change is breaking the logic of the probe. Test is failing.
| if (service == NULL) { | ||
| return -1; | ||
| } | ||
| else { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes for #2257