Do not render monorail stations #75
Open
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disables labels for monorail stations in the station labeling layers.
Disable labels for monorail stations in the station labeling layers.
Disable labels for monorail stations in the station labeling layers.
|
I wonder if one can't just tell the database to filter out those stations in the SELECT so the actual rendering code will never see them. |
|
I'll look at that. Stations are interesting since there's a lack of standardization or maybe lack of precision: we show miniature stations sometimes since there's no station=miniature flag. |
Nakaner
requested changes
Oct 22, 2022
| [railway = 'halt'][station != 'funicular'][zoom >= 10], | ||
| [railway != 'tram_stop'][station != 'funicular'][zoom >= 11] { | ||
| [railway = 'station'][station != 'funicular'][station != 'monorail'][monorail != 'yes'][zoom >= 10], | ||
| [railway = 'halt'][station != 'funicular'][station != 'monorail'][zoom >= 10], |
There was a problem hiding this comment.
Did you intentionally skip `[monorail != 'yes'] here?
There was a problem hiding this comment.
There are only 7 nodes I can find where this makes a difference, funny enough all of them are in Germany (Dortmund, Dresden, Europa-Park). Maybe just merge it as is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #43
looks for station=monorail and/or monorail=yes.