Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: disable tailwind preflight from ui-core and ui-chart #1016

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

RostomBoudi
Copy link

@RostomBoudi RostomBoudi commented Apr 3, 2025

Disable tailwind preflight to prevent css from spilling over.

A lot of preflight apply css to everything (*), which may break application using osrd-ui.

@import tailwindcss/base should also be removed as it contain preflight and is redondant (as tailwindcss/components and tailwindcss/utilities are already imported).

Closes: #988

@RostomBoudi RostomBoudi marked this pull request as ready for review April 3, 2025 13:07
@RostomBoudi RostomBoudi requested a review from a team as a code owner April 3, 2025 13:07
@emersion
Copy link
Member

emersion commented Apr 3, 2025

I can confirm that the leaking styles are gone now. Unfortunately it seems like various components are broken: the button no longer has a hand cursor on hover, the manchette is missing borders, and so on.

@RostomBoudi RostomBoudi marked this pull request as draft April 3, 2025 15:48
@RostomBoudi
Copy link
Author

RostomBoudi commented Apr 3, 2025

I can confirm that the leaking styles are gone now. Unfortunately it seems like various components are broken: the button no longer has a hand cursor on hover, the manchette is missing borders, and so on.

Darn ! Sorry, my bad.
I will try to find something else 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

osrd-ui stylesheets leak outside of osrd-ui components
2 participants