Fix a crash bug on Windows (didn't strdup the userconfig value)

OpenPrinting · Oct 21, 2024 · 7c91113 · 7c91113
1 parent fa40ddc
commit 7c91113
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -11,6 +11,7 @@ libcups v3.0rc3 (YYYY-MM-DD)
   credential removal as documented.
 - Updated the raster functions to report more issues via
   `cupsRasterGetErrorString`.
+- Fixed a crash bug on Windows.
 
 
 libcups v3.0rc2 (2024-10-15)

diff --git a/cups/globals.c b/cups/globals.c
@@ -159,8 +159,8 @@ cups_globals_alloc(void)
   HKEY		key;			// Registry key
   DWORD		size;			// Size of string
   static char	installdir[1024] = "",	// Install directory
-		userconfig[1024] = "",	// User configuration directory
 		sysconfig[1024] = "";	// Server configuration directory
+  char		userconfig[1024] = "",	// User configuration directory
 #endif // _WIN32
 
 
@@ -245,7 +245,7 @@ cups_globals_alloc(void)
     DEBUG_printf("cups_globals_alloc: userconfig=\"%s\"", userconfig);
   }
 
-  cg->userconfig = userconfig;
+  cg->userconfig = strdup(userconfig);
 
 #else
   const char	*home = getenv("HOME");	// HOME environment variable