Don't need to guard against free(NULL), pickup code tweak in PDFio.

OpenPrinting · Feb 22, 2025 · 208f920 · 208f920
1 parent 99fc84b
commit 208f920
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 28 deletions.
diff --git a/cups/encode.c b/cups/encode.c
@@ -1,7 +1,7 @@
 //
 // Option encoding routines for CUPS.
 //
-// Copyright © 2021-2024 by OpenPrinting.
+// Copyright © 2021-2025 by OpenPrinting.
 // Copyright © 2007-2019 by Apple Inc.
 // Copyright © 1997-2007 by Easy Software Products.
 //
@@ -503,8 +503,7 @@ _cupsEncodeOption(
 	  {
 	    cupsFreeOptions(num_cols, cols);
 
-	    if (copy)
-	      free(copy);
+	    free(copy);
 
 	    ippDeleteAttribute(ipp, attr);
 	    return (NULL);
@@ -521,8 +520,7 @@ _cupsEncodeOption(
     }
   }
 
-  if (copy)
-    free(copy);
+  free(copy);
 
   return (attr);
 }

diff --git a/cups/file.c b/cups/file.c
@@ -6,7 +6,7 @@
 // our own file functions allows us to provide transparent support of
 // different line endings, gzip'd print files, etc.
 //
-// Copyright © 2021-2024 by OpenPrinting.
+// Copyright © 2021-2025 by OpenPrinting.
 // Copyright © 2007-2019 by Apple Inc.
 // Copyright © 1997-2007 by Easy Software Products, all rights reserved.
 //
@@ -141,9 +141,7 @@ cupsFileClose(cups_file_t *fp)		// I - CUPS file
   fd   = fp->fd;
   mode = fp->mode;
 
-  if (fp->printf_buffer)
-    free(fp->printf_buffer);
-
+  free(fp->printf_buffer);
   free(fp);
 
   // Close the file, returning the close status...

diff --git a/pdfio b/pdfio
diff --git a/tools/ippeveprinter.c b/tools/ippeveprinter.c
@@ -1986,8 +1986,7 @@ delete_job(ippeve_job_t *job)		// I - Job
 
   ippDelete(job->attrs);
 
-  if (job->message)
-    free(job->message);
+  free(job->message);
 
   if (job->filename)
   {
@@ -2018,22 +2017,14 @@ delete_printer(
 
   cupsDNSSDDelete(printer->dnssd);
 
-  if (printer->dnssd_name)
-    free(printer->dnssd_name);
-  if (printer->name)
-    free(printer->name);
-  if (printer->icons[0])
-    free(printer->icons[0]);
-  if (printer->strings)
-    free(printer->strings);
-  if (printer->command)
-    free(printer->command);
-  if (printer->device_uri)
-    free(printer->device_uri);
-  if (printer->directory)
-    free(printer->directory);
-  if (printer->hostname)
-    free(printer->hostname);
+  free(printer->dnssd_name);
+  free(printer->name);
+  free(printer->icons[0]);
+  free(printer->strings);
+  free(printer->command);
+  free(printer->device_uri);
+  free(printer->directory);
+  free(printer->hostname);
 
   ippDelete(printer->attrs);
   cupsArrayDelete(printer->jobs);