PHP 7.4 fixes

build

@@ -50,6 +50,7 @@ SITECONFPHP="../inc/siteconf.php"
 	    perl -p -e "s:\@DRIVERDIR\@:$DRIVERDIR:" | \
 	    perl -p -e "s:\@DRIVERDIRURL\@:$DRIVERDIRURL:" | \
 	    perl -p -e "s:\@PPDDIRURL\@:$PPDDIRURL:" | \
+	    perl -p -e "s:\@WORKDIR\@:$WORKDIR:" | \
 	    perl -p -e "s:\@LIBDIR\@:$ALIBDIR:" > ${file%.in}
 	chmod +x ${file%.in}
     done

composer.json

@@ -0,0 +1,21 @@
+{
+    "name": "openprinting/foomatic-db-webapp",
+    "description": "Web application for openprinting.org",
+    "type": "project",
+    "require": {
+        "smarty/smarty": "^5.3",
+        "apereo/phpcas": "^1.3"
+    },
+    "license": "GPL-2.0-or-later",
+    "authors": [
+        {
+            "name": "Lance Albertson",
+            "email": "[email protected]"
+        }
+    ],
+    "config": {
+        "platform": {
+            "php": "7.4"
+        }
+    }
+}

driver_detail.php

@@ -6,22 +6,22 @@
 	exit;
 }
 
-$drivertypes = array(
+$drivertypes = [
     "ghostscript" => 'Ghostscript built-in',
     "uniprint" => 'Ghostscript Uniprint',
     "filter" => 'Filter',
     "ijs" => 'IJS',
     "cups" => 'CUPS Raster',
     "opvp" => 'OpenPrinting Vector',
-    "postscript" => 'PostScript');
+    "postscript" => 'PostScript'];
 
-$driverparameters = array(
+$driverparameters = [
     "text" => 'Text',
     "lineart" => 'Line Art',
     "graphics" => 'Graphics',
     "photo" => 'Photo',
     "load_time" => 'System Load',
-    "speed" => 'Speed');
+    "speed" => 'Speed'];
 
 $PAGE->setPageTitle('Driver: ' . $_GET['driver']);
 $PAGE->setActiveID('driver');
@@ -56,7 +56,7 @@
 // printer ID in such a case.
 foreach($printers as $pr) {
   if (strlen($pr['make']) == 0) {
-    $matches = array();
+    $matches = [];
     if (preg_match("/^([^\-]+)\-(.*)$/", $pr['id'], $matches) != 0) {
       $printers[$pr['id']]['make'] =
 	preg_replace("/_+/", " ", $matches[1]);
@@ -96,7 +96,7 @@
     $mask = "{$_GET['driver']};openprinting-{$_GET['driver']};" .
 	"openprinting-ppds-{$_GET['driver']}";
 }
-$out = array();
+$out = [];
 exec("cd foomatic; ./packageinfo " . escapeshellarg($mask), $out, $ret_value);
 if (sizeof($out) > 0)
     $packagedownloads = $out[0];
@@ -244,7 +244,7 @@
     $infobox .= "</font></td>" .
 	"<td width=\"2%\"></td></tr>";
 }
-if (is_array($contacts) and count($contacts) > 0) {
+if (is_[$contacts] and count($contacts) > 0) {
     $infobox .= "<tr valign=\"top\"><td width=\"2%\"></td>" .
 	"<td width=\"16%\"><font size=\"-2\">" .
 	"User support:" .
@@ -289,8 +289,8 @@
     strlen($driver['graphics']) > 0 or strlen($driver['photo']) > 0 or
     strlen($driver['load_time']) > 0 or strlen($driver['speed']) > 0) {
     $infobox .= "<tr valign=\"top\"><td width=\"2%\"></td>";
-    foreach(array('text', 'graphics', 'load_time',
-		  'lineart', 'photo', 'speed') as $par) {
+    foreach(['text', 'graphics', 'load_time',
+		  'lineart', 'photo', 'speed'] as $par) {
 	$infobox .= "<td width=\"16%\"><font size=\"-2\">" .
 	    "{$driverparameters[$par]}:</font></td>" .
 	    "<td width=\"16%\"><font size=\"-2\">";
@@ -332,7 +332,7 @@
 	"</font></td>" .
 	"<td width=\"2%\"></td></tr>";
 }
-if (is_array($dependencies) and count($dependencies) > 0) {
+if (is_[$dependencies] and count($dependencies) > 0) {
     $infobox .= "<tr valign=\"top\"><td width=\"2%\"></td>" .
 	"<td width=\"16%\"><font size=\"-2\">" .
 	"<b>Dependencies:</b>" .

driver_list.php

@@ -1,14 +1,14 @@
 <?php
 include('inc/common.php');
 
-$drivertypes = array(
+$drivertypes = [
     "ghostscript" => 'Ghostscript&nbsp;built-in',
     "uniprint" => 'Ghostscript&nbsp;Uniprint',
     "filter" => 'Filter',
     "ijs" => 'IJS',
     "cups" => 'CUPS&nbsp;Raster',
     "opvp" => 'OpenPrinting&nbsp;Vector',
-    "postscript" => 'PostScript');
+    "postscript" => 'PostScript'];
 
 $SMARTY->assign("drivertypes",$drivertypes);
 

foomatic/query.in

@@ -7,6 +7,7 @@
 use Digest::MD5 qw(md5_hex);
 use strict;
 
+use lib "@WORKDIR@";
 use lib "@LIBDIR@";
 use Foomatic::Defaults;
 use Foomatic::DB;

inc/common.php

@@ -1,21 +1,20 @@
 <?php
 
+require __DIR__ . '/../vendor/autoload.php';
+
 // TODO: do we have to include PHPMailer on every page?
 include('PHPMailer/class.phpmailer.php');
 
 include('inc/siteconf.php');
 $CONF = new SiteConfig();
-include($CONF->casModulePath . '/CAS.php');
-
 include('inc/db.php');
-include('inc/smarty/SmartyBC.class.php');
 include('inc/page.php');
 
 session_start();
 error_reporting(E_ALL);
 
-$SMARTY = new SmartyBC();
-$SMARTY->clear_compiled_tpl();
+use Smarty\Smarty;
+$SMARTY = new Smarty();
 
 $PAGE = Page::getInstance();
 $PAGE->setSmarty($SMARTY);