Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override 404 error page #22

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Override 404 error page #22

merged 1 commit into from
Mar 12, 2024

Conversation

xmcp
Copy link
Contributor

@xmcp xmcp commented Mar 12, 2024

This PR fixes #21.

I have tested the patch by manually modifying the /etc/nginx/openmediavault-webgui.d/openmediavault-webdav.conf file.

Before modifying:

$ curl -u user:pass -v http://host/webdav/nonexistent
...
< HTTP/1.1 302 Moved Temporarily
...

After modifying:

$ curl -u user:pass -v http://host/webdav/nonexistent
...
< HTTP/1.1 404 Not Found
...

@ryecoaaron ryecoaaron merged commit a479915 into OpenMediaVault-Plugin-Developers:master Mar 12, 2024
@ryecoaaron
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP status code for non-existent paths is 302 instead of 404
2 participants