Fix division by zero in [z]rotg #4235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cases [ c s ] * [ 0 ] = [ |db_i| ] [-s c ] [ i*db_i ] [ 0 ] and [ c s ] * [ 0 ] = [ |db_r| ] [-s c ] [ db_r ] [ 0 ] computed s incorrectly. To flip the entries of vector, s should be conjg(db)/|db| and not conjg(db) / da, where da == 0.0.
* The check da != ZERO is no longer necessary since there is a special case ada == ZERO, where ada = |da|. * Add the missing check c != ZERO before the division. Note that with these two changes the long double code follows the float/double version of the code.
|
@vladimir-ch You have commented on rotg before and may want to have a look |
|
Thanks for the notification @angsch. I've checked and our Gonum BLAS already has this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix division by zero.
With that
ifcondition, the division byda_rcorresponds to a division by zero.OpenBLAS/interface/zrotg.c
Lines 63 to 68 in bb2f1ec
Fixed to such that
S = conjg(db)/|db|Remove redundant branch.
With the algorithm change in reference LAPACK, the case
da == ZEROis a special branch.OpenBLAS/interface/rotg.c
Line 34 in bb2f1ec
OpenBLAS/interface/rotg.c
Lines 51 to 56 in bb2f1ec
Consequently, there is no longer the need to check.
OpenBLAS/interface/rotg.c
Line 69 in bb2f1ec
The commit removes the branch.
Add missing check for zero.
OpenBLAS/interface/rotg.c
Lines 72 to 73 in bb2f1ec
does not have a check
c != 0in the long double code. The float/double version does have this check. The new code is essentially identical to the float/double version