Feature/2021 10 22 fixes #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- handle missing parameters - removed deprecated rewrite rule
TallTed
reviewed
Oct 22, 2021
| @@ -659,7 +659,7 @@ post_process_err_with_log4v: | |||
|
|
|||
| </li> | |||
| <li> | |||
| <a class="desc_permalink" href="<?vsp http (fct_make_curie (sprintf ('%s&distinct=%d', plink_href, equ (dist, 0)), lines)); ?>" title="This link enables you toggle between normalized and un-normalized views of data using by applying or note applying a DISTINCT operator"> | |||
| <a class="desc_permalink" href="<?vsp http (fct_make_curie (sprintf ('%s&distinct=%d', plink_href, equ (dist, 0)), lines)); ?>" title="This link enables you toggle between normalized and un-normalized views of data using by applying or note applying a DISTINCT operator"> | |||
There was a problem hiding this comment.
Suggested change
| <a class="desc_permalink" href="<?vsp http (fct_make_curie (sprintf ('%s&distinct=%d', plink_href, equ (dist, 0)), lines)); ?>" title="This link enables you toggle between normalized and un-normalized views of data using by applying or note applying a DISTINCT operator"> | |
| <a class="desc_permalink" href="<?vsp http (fct_make_curie (sprintf ('%s&distinct=%d', plink_href, equ (dist, 0)), lines)); ?>" title="This link enables you to toggle between normalized and un-normalized views of data, by applying or not applying a DISTINCT operator"> |
TallTed
reviewed
Oct 22, 2021
|
|
||
| rss := getrusage(); | ||
|
|
||
| http ('<a href="http://www.openlinksw.com/virtuoso/">OpenLink Virtuoso</a> version '); | ||
| http (sprintf ('%s as of %s', sys_stat ('st_dbms_ver'), sys_stat('st_build_date'))); |
There was a problem hiding this comment.
@pkleef @openlink @imitko @smalinin @kidehen @HughWilliams @mitache @IvanMikhailov
Can we please start to include git_head info here (and anywhere else st_dbms_ver is displayed/output)?
st_build_date doesn't provide any insight into the instance version, only the date of its compilation -- which has no relation to when the st_dbms_ver was set nor when the code being compiled was obtained from the repo. st_dbms_ver is also disconnected from the human/marketing "version", e.g., VOS 7.2.6.1 does not correspond to an st_dbms_ver of 07.20.06.01 nor 07.02.06.01.
TallTed
added a commit
that referenced
this pull request
Nov 3, 2021
re-improves human-facing language, by re-applying [previously unapplied change request](#21 (review))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.