Skip to content

OLMIS-8179: Compact dose and pack inputs#80

Open
michaldev0 wants to merge 3 commits into
masterfrom
OLMIS-8179-compact-inputs
Open

OLMIS-8179: Compact dose and pack inputs#80
michaldev0 wants to merge 3 commits into
masterfrom
OLMIS-8179-compact-inputs

Conversation

@michaldev0

Copy link
Copy Markdown
Contributor

Doses mode input shows a gray 'doses' placeholder. Packs mode no longer shows the Doses placeholder.

Doses mode input shows a gray 'doses' placeholder. Packs mode no longer shows the Doses placeholder.
"openlmisInputDosesPacks.Packs": "Packs",
"openlmisInputDosesPacks.DosesBracket":" doses )"
"openlmisInputDosesPacks.DosesBracket":" )",
"openlmisInputDosesPacks.DosesHint": "doses"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed here? Couldn't openlmisInputDosesPacks.Doses be used here as is in Packs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gray hint text for doses is required to start with a small letter, not capital, so it's a different case.

Comment thread src/openlmis-quantity-unit-input/messages_en.json Outdated
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants