Limit configuration requirements to necessary requirements#38
Merged
Conversation
- Cloud mode: Only requires OpenHands Cloud API key - Local mode: Requires LLM API key, GitHub token, and agent server URL Changes: - Updated ConfigContext validation logic (calculateIsConfigured) to have different requirements for cloud vs local modes - Updated ConfigPage UI: - Hide environment toggle on Vercel (cloud-only deployment) - Hide LLM Provider and GitHub sections when in cloud mode (they're not needed) - Added clear requirements explanation banner showing what's needed for each mode - Simplified messaging on Vercel to just show 'You only need an OpenHands Cloud API key' - Updated tests to reflect new UI behavior - Added comprehensive tests for configuration validation logic Fixes #37 Co-authored-by: openhands <openhands@all-hands.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the configuration requirements simplification as requested in issue #37.
Changes
Configuration Validation Logic (ConfigContext.tsx)
Updated
calculateIsConfigured()function to have different requirements based on execution environment:sessionApiKey)ConfigPage UI Updates (ConfigPage.tsx)
On Vercel (cloud-only deployment):
When running locally (not on Vercel):
Added requirements explanation banner:
Test Updates
Screenshots
The configuration page now:
Testing
Fixes #37
@neubig can click here to continue refining the PR