Conversation
all-hands-bot
left a comment
There was a problem hiding this comment.
Found several issues that should be addressed, particularly missing critical guidance sections. Details in inline comments.
| * If the changes are in unrelated files, just ignore them and don't revert them. | ||
| - Do not amend a commit unless explicitly requested to do so. | ||
| - While you are working, you might notice unexpected changes that you didn't make. If this happens, STOP IMMEDIATELY and ask the user how they would like to proceed. | ||
| - **NEVER** use destructive commands like `git reset --hard` or `git checkout --` unless specifically requested or approved by the user. |
There was a problem hiding this comment.
🔴 Critical: This template is missing several essential sections that are present in the main system_prompt.j2:
- VERSION_CONTROL: Git best practices, commit guidelines, handling of git credentials
- PULL_REQUESTS: Important guidance about not pushing to main, PR management
- CODE_QUALITY: Clean code principles, minimal changes, import placement
- EFFICIENCY: Combining actions, using efficient tools
- FILE_SYSTEM_GUIDELINES: Proper file handling, not creating multiple file versions
- ROLE: Clarifying the agent's purpose and behavior
While this template includes some git guidance in the "Editing constraints" section (lines 34-41), it's much less comprehensive. Without these sections, the agent may:
- Push directly to main branch
- Create inefficient multi-file versions (file_v1.py, file_v2.py, etc.)
- Make overly defensive code changes
- Not properly handle git credentials
Recommendation: Either include these sections or document why they're intentionally excluded for GPT-5 Codex. If the intention is that this template extends the base template, that should be clearly documented.
There was a problem hiding this comment.
Without these sections, the agent may:
- Push directly to main branch
- Create inefficient multi-file versions (file_v1.py, file_v2.py, etc.)
Claude dear, that’s just you.
|
[Automatic Post]: It has been a while since there was any activity on this PR. @enyst, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up. |
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
|
[Automatic Post]: It has been a while since there was any activity on this PR. @enyst, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up. |
|
[automated message] @neubig assigned for review according to git blame |
This PR adds a new
system_prompt_gpt_5_codex.j2template tailored for GPT-5 Codex usage within the OpenHands Software Agent SDK.Key points:
gpt-5.2-codex_prompt.md).task_trackertool usage (replacing Codex's "Plan tool" description where appropriate).apply_patchtool usage description compatible with OpenHands.AGENTS.mdspec support.This template is intended for the Codex variant of GPT-5 agent.
@enyst can click here to continue refining the PR
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:5549cb8-pythonRun
All tags pushed for this build
About Multi-Architecture Support
5549cb8-python) is a multi-arch manifest supporting both amd64 and arm645549cb8-python-amd64) are also available if needed