Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
left a comment
There was a problem hiding this comment.
🟡 Acceptable - Solves a real problem (agents being asked to "modify yourself"), but SKILL.md is too dense for progressive disclosure. Main issue: section 3 turns into a uv technical manual when it should stay a decision guide.
Co-authored-by: openhands <openhands@all-hands.dev>
enyst
left a comment
There was a problem hiding this comment.
Addressed the review feedback:
- Trimmed SKILL.md section 3 to stay high-level and moved details to references/INSTALLATION_MODES.md.
- Clarified MCP config locations: CLI uses ~/.openhands/mcp.json (or $OPENHANDS_PERSISTENCE_DIR/mcp.json); SDK skills/plugins use per-skill/per-plugin .mcp.json.
- Updated hooks template to parse structured JSON with jq and return {decision: allow|deny}.
- Reworded the opening clarification guidance to avoid unnecessary “one at a time” ceremony.
Pushed in 52633f7.
Co-authored-by: openhands <openhands@all-hands.dev>
|
Rename update:
|
all-hands-bot
left a comment
There was a problem hiding this comment.
🟡 Acceptable - Solves a real problem and the structure is sound after previous revisions. Main issue: one overly-generic trigger that will cause false positives.
Co-authored-by: openhands <openhands@all-hands.dev>
|
Pulled your latest tweaks (
Pushed in 3c3536c. |
Co-authored-by: openhands <openhands@all-hands.dev>
|
Updated section “Add tools via MCP” to be more restrictive:
Pushed in 5063dcb. |
Co-authored-by: openhands <openhands@all-hands.dev>
|
Pulled latest (
Pushed in 682ba1e. |
Co-authored-by: openhands <openhands@all-hands.dev>
|
Did a Changes:
Pushed in 4e5e8ca. |
|
@OpenHands Address the inline review threads. Fix here. |
|
I'm on it! enyst can track my progress at all-hands.dev |
Co-authored-by: openhands <openhands@all-hands.dev>
|
No further changes were needed after my last update; the PR is already updated and pushed. Checklist (per your instructions)
|
all-hands-bot
left a comment
There was a problem hiding this comment.
🟡 Acceptable - Solves a real problem and the structure is solid after previous revisions. One minor clarity issue about persistence scope.
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Clean solution after review iterations.
VERDICT: ✅ Worth merging
KEY INSIGHT: This skill correctly inverts the default behavior—instead of agents immediately editing Python code when asked to "modify yourself", they now have a decision tree for choosing the smallest, safest extensibility mechanism (skills → hooks → plugins → code).
The structure is sound:
- Decision tree in SKILL.md with details separated into references/ (proper progressive disclosure)
- Templates show correct patterns (jq for JSON parsing, env vars for secrets, explicit warnings about "break glass" overrides)
- Triggers are distinctive enough (OpenHands-specific paths like
hooks.json,.agents/skills) - Addresses a real problem pragmatically
No critical issues found. Previous review rounds successfully addressed the generic triggers, MCP config clarity, and template robustness.
|
@OpenHands Port this Skill, the PR’s diff, in enyst/.openhands/ at the right place, so we play with it. Clone, etc. |
|
I'm on it! enyst can track my progress at all-hands.dev |
|
I did not make any code changes in the repo during this activity (no commits, no pushes). I only inspected the workspace to understand where the Summary of work performed
Completion checklist
|
Adds a new skill (
adapt-yourself) that teaches agents/users how to make persistent behavior changes by choosing the right extensibility mechanism:.agents/skills)AGENTS.md).openhands/hooks.json)~/.openhands/mcp.json; SDK skills/plugins: per-skill.mcp.json)Also includes references covering uv +
uv tool installworkflows and version pinning, plus templates.Changes:
skills/adapt-yourself/(SKILL.md, README, references).plugin/marketplace.jsonValidation:
python -m json.tool .plugin/marketplace.json