Skip to content

Fix YieldingPauserTest flakiness #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix YieldingPauserTest flakiness #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/test/java/net/openhft/chronicle/threads/YieldingPauserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ public void pause() {
} catch (TimeoutException e) {
final long time = System.currentTimeMillis() - start;
// delta used to be 5 for Linux but occasionally we see it blow in Continuous Integration
// a delta of 20 was used here, however in some situations in CI that was not sufficient:
// org.opentest4j.AssertionFailedError: expected: <100.0> but was: <126.0>
int delta = 30;
// a delta of 30 was used here, however in some situations in CI that was not sufficient:
// org.opentest4j.AssertionFailedError: expected: <100.0> but was: <133.0>
int delta = 50;
// please don't add delta to pauseTimeMillis below - it makes this test flakier on Windows
assertEquals(pauseTimeMillis, time, delta);
tp.reset();
Expand Down