Skip to content

Conversation

yungcomputerchair
Copy link
Member

This PR enables auth cookies to be used simultaneously with plaintext paasswords sent in the cookie authID field.

  • Hoist a bunch of checks from the login packet handler into helper functions.
  • Rename the LoginType enum to AuthMethod and distinguish it from the iLoginType packet field (see comment in code for why these should be decoupled).
  • If the provided token does not pass the cookie check and password auth is enabled, treat it as a plaintext password and authenticate if it is correct.

@dongresource dongresource merged commit 55cf3f7 into master Nov 17, 2024
6 checks passed
@yungcomputerchair yungcomputerchair deleted the auth branch November 17, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants