Skip to content
This repository was archived by the owner on Dec 31, 2024. It is now read-only.

Include final fields when converting a POJO to a map #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
language: java

jdk:
- oraclejdk8
- openjdk8

install:
./mvnw --settings .settings.xml install -DskipTests=true -Dmaven.javadoc.skip=true -Dgpg.skip -B -V
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,17 @@

import lombok.AllArgsConstructor;
import lombok.Data;
import lombok.NoArgsConstructor;
import lombok.experimental.FieldDefaults;
import org.springframework.web.multipart.MultipartFile;

@Data
@NoArgsConstructor
@AllArgsConstructor
@FieldDefaults(level = PRIVATE)
public class Dto implements Serializable {

private static final long serialVersionUID = -4218390863359894943L;

String field1;
final String field1;

int field2;

Expand Down
3 changes: 1 addition & 2 deletions feign-form/src/main/java/feign/form/util/PojoUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package feign.form.util;

import static java.lang.reflect.Modifier.isFinal;
import static java.lang.reflect.Modifier.isStatic;
import static lombok.AccessLevel.PRIVATE;

Expand Down Expand Up @@ -63,7 +62,7 @@ public static Map<String, Object> toMap (@NonNull Object object) {
val setAccessibleAction = new SetAccessibleAction();
for (val field : type.getDeclaredFields()) {
val modifiers = field.getModifiers();
if (isFinal(modifiers) || isStatic(modifiers)) {
if (isStatic(modifiers)) {
continue;
}
setAccessibleAction.setField(field);
Expand Down