[Edge] Refactor OpenWB EVCS integration #3455
Open
+357
−257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update significantly refactors the OpenWB EVCS integration for improved reliability and maintainability. Changes include the removal of the ReadWorker class in favor of using the BridgeHttpFactory and HttpBridgeCycleServiceDefinition for handling HTTP requests to the OpenWB API. This approach simplifies the codebase by leveraging existing infrastructure for HTTP communications, thereby reducing custom network handling code. Additionally, SSL certificate validation for OpenWB's self-signed certificates is now globally disabled within this component to prevent connection issues. The update also introduces more granular handling of OpenWB's API responses for statuses, power, energy, and other metrics, improving the accuracy and responsiveness of the EVCS component. This refactor ensures better alignment with OpenEMS architecture and prepares the ground for future enhancements.
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (19.17%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #3455 +/- ##
==============================================
+ Coverage 29.13% 59.51% +30.38%
- Complexity 0 112 +112
==============================================
Files 291 2900 +2609
Lines 8116 124994 +116878
Branches 1386 9354 +7968
==============================================
+ Hits 2364 74379 +72015
- Misses 5629 47796 +42167
- Partials 123 2819 +2696 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update significantly refactors the OpenWB EVCS integration for improved reliability and maintainability. Changes include the removal of the ReadWorker class in favor of using the BridgeHttpFactory and HttpBridgeCycleServiceDefinition for handling HTTP requests to the OpenWB API. This approach simplifies the codebase by leveraging existing infrastructure for HTTP communications, thereby reducing custom network handling code. Additionally, SSL certificate validation for OpenWB's self-signed certificates is now globally disabled within this component to prevent connection issues. The update also introduces more granular handling of OpenWB's API responses for statuses, power, energy, and other metrics, improving the accuracy and responsiveness of the EVCS component. This refactor ensures better alignment with OpenEMS architecture and prepares the ground for future enhancements.