Add design skills and verification tools

[mereyabdenbekuly-ctrl]

Summary

• Add 15 new design skills for Open CoDesign
• Add accessibility and code quality verification tools
• Add enhanced prompt optimization, multi-agent support, and reference library structure

Notes

• Local branch contains 6 commits ahead of upstream main.

[github-actions]

Review mode: initial

Findings

• [Major] packages/core/src/orchestrate-multi-agent.ts uses console.log() on multiple lines (e.g., lines 40, 47, 49, 83, etc.) — this violates the project constraint in CLAUDE.md that bans console.* in packages/core/**. Use the injected CoreLogger instead.
  Suggested fix: Replace all console.log calls with a logger instance (e.g., getLogger('multi-agent')) or inject a logger through the module signature.

• [Major] No tests added for any of the 28 new/changed files. Per CLAUDE.md, new features require at least one Vitest test. The critic agent, improver agent, orchestration, verification tools, and reference library are untested and should have basic unit tests.
  Suggested fix: Add Vitest tests covering at least one function per new module (e.g., criticAgent mock path, shouldSkipImprovement, verifyAccessibility, verifyCodeQuality, loadExamplesByCategory with stubs).

• [Minor] packages/core/src/agents/improver-agent.ts (line ~90) uses as any on the return value, which bypasses TypeScript strict mode. The project forbids any.
  Suggested fix: Either properly type the return or throw a more meaningful error indicating this is placeholder scaffolding.

• [Minor] packages/core/src/reference-library.ts uses synchronous fs.readFileSync and fs.existsSync inside async functions (loadExamplesByCategory, loadAllExamples), blocking the event loop. When used in a real agent context during generation, this can degrade performance.
  Suggested fix: Use fs.promises (readFile, access, readdir) with await in these async functions.

• [Minor] No changeset included. If this PR introduces user-visible features (e.g., multi-agent generation or verification tools), it should include a changeset (pnpm changeset). If it's pure scaffolding/docs, the description should clarify that.
  Suggested fix: Either add a changeset (if user-visible) or update the PR body to state "no user-visible changes — scaffolding and documentation."

• [Note] The multi-agent orchestration (orchestrate-multi-agent.ts) is currently scaffolding: generateViaAgent throws an error, criticAgent returns a mock with all-zero scores, and improverAgent returns the original artifact with as any. These modules cannot be executed in their current form. This is acceptable as a first iteration if followed up by actual implementation, but the PR should explicitly mark this as partial work (e.g., "refs" rather than "closes").

• [Note] The verification tools (verify-accessibility.ts, verify-code-quality.ts) and reference-library.ts are well-documented but not yet integrated into the agent pipeline. Consider linking them from the orchestrator or adding a follow-up issue for integration.

Summary

This PR introduces substantial scaffolding for multi-agent generation, prompt engineering, verification tools, reference library, and 15 design skills. The structure is logical and well-documented, but it has several issues that prevent immediate merging: console.log usage in a banned path, missing tests, any type bypasses, and synchronous file I/O. Once these are addressed, and the PR is scoped as scaffolding (not production-ready code), it can be merged in a follow-up iteration.

Open-CoDesign Bot

[github-actions]

Review mode: follow-up after new commits

Findings

• [Major] Previous findings (console.log in packages/core/, missing tests, as any bypass, synchronous fs calls, no changeset) remain entirely unaddressed in this follow-up push. The code added or unchanged in this commit still violates project constraints. All previously filed issues must be resolved before merge.

• [Major] New file CLOUD-DESIGN-V2-COMPLETE.md is a disconnected, fantastical planning document. It describes fictional "Cloud Design" infrastructure (15 kW power budgets, Noctua fans, Lighthouse-based performance metrics) and references non-existent packages like '@open-design/core' instead of '@open-codesign/core'. This document does not correspond to the actual codebase and misleads about project scope. It must be excluded from the repo or rewritten as a clear internal plan that references real package names and feasible architecture. The integration steps shown (e.g., packages/core/src/tools/done.ts) do not exist.
  Suggested fix: Remove CLOUD-DESIGN-V2-COMPLETE.md from the PR, or replace it with a concise, accurate design document that aligns with the project's actual structure and constraints.

• [Major] New file packages/core/src/orchestrate-multi-agent-ft.ts repeats the same console.* violations (console.log, console.warn, console.error, console.info throughout) and uses synchronous fs I/O (fs.existsSync, fs.mkdirSync, fs.writeFileSync, fs.readFileSync, fs.unlinkSync) in what is nominally an async workflow — blocking the event loop. It also uses deprecated Math.random().toString(36).substr(2, 9) (use .substring()), returns any from getCircuitStats(), and imports from ../types which may not exist as a type export for GenerateInput/GenerateOutput (the project uses @open-codesign/shared).
  Suggested fix: Replace all console.* with a logger; convert sync file operations to fs.promises with await; fix substr to substring; type the return of getCircuitStats properly; verify and correct import paths.

• [Major] No tests added for any of the ~15 new modules in this PR (critic agent, improver agent, verification tools, reference library, orchestration). Per CLAUDE.md requirements, new features need at least one Vitest test. This is a repeat of the previous review's finding.
  Suggested fix: Add Vitest unit tests for at least one key function per new module (e.g., shouldSkipImprovement, verifyAccessibility, loadExamplesByCategory).

• [Minor] The FaultTolerantMultiAgent constructor defaults to /tmp/clodex-checkpoints as checkpoint directory. This hardcoded path is not portable (won't exist on Windows, and may be cleaned by OS on macOS/Linux). Use path.join(app.getPath('userData'), 'checkpoints') or a similarly configurable location.

• [Minor] packages/core/src/orchestrate-multi-agent-ft.ts line ~155: config.skipImproveThreshold || 85 — if skipImproveThreshold is 0, this will incorrectly default to 85. Use config.skipImproveThreshold ?? 85.

• [Note] The PR body claims "Add 15 new design skills" — these skills exist as markdown in skills/ but are not wired into any agent pipeline. They are documentation only. The same applies to the verification tools: verify-accessibility-runtime.ts imports playwright and axe-core but these are not in packages/core/package.json dependencies; the file currently fails at runtime. Clarify PR scope or add missing dependencies.

Summary

This follow-up push adds two files that introduce new issues (CLOUD-DESIGN-V2-COMPLETE.md and orchestrate-multi-agent-ft.ts) while leaving all previously flagged problems unresolved. The PR remains a collection of well-structured scaffolding that cannot be executed or tested. It should not be merged until: (1) console.* is replaced with a logger, (2) synchronous fs is replaced with async, (3) tests are added, (4) the CLOUD-DESIGN-V2-COMPLETE.md document is removed or rewritten to match the project, and (5) a changeset is included for any user-visible changes. If this is intended as purely incremental scaffolding, the PR description and labels should reflect that.

Open-CoDesign Bot