Open
Conversation
- Upgrade PHPstan & fix issues - Add rector (no rules applied yet) - Fix phplint cache dir
johanib
commented
Jan 22, 2026
- Cleanup composer.json by removing non-existant namespaces - Apply rectors: * ThisCallOnStaticMethodToStaticCallRector * NullToStrictStringFuncCallArgRector * RemoveUselessReturnTagRector * AnnotationToAttributeRector * RenameAttributeRector - User Deprecated: Since symfony/http-kernel 6.3: Parameter "container.dumper.inline_class_loader" is deprecated, use ".container.dumper.inline_class_loader" instead.
sass-migrator division assets/scss/**/*.scss Remove warnings like during compilation: Module Warning (from ./node_modules/sass-loader/dist/cjs.js): Deprecation Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. Recommendation: math.div(18em, 14) or calc(18em / 14)
`js-yaml` was introduced as a resolution, then kept around. It's not needed.
johanib
force-pushed
the
feature/upgrade
branch
from
8603c4c to
209c8e3
Compare
MKodde
reviewed
Jan 29, 2026
MKodde
approved these changes
Jan 29, 2026
Member
There was a problem hiding this comment.
While testing the changes in my dev environment, I found out quite some SASS parser deprecation warnings remain in the project. No blocker for me, just saying..
Also: while testing, I noticed your frontend-install modifications you made in the other projects is not included here. Leaving me with permission issues after running the frontend install task. Maybe add the following section here?
"frontend-install": [
"yarn install",
"yarn encore prod",
"./bin/console cache:clear",
"@fix-dev-permissions"
],
"fix-dev-permissions": [
"chown -R www-data:www-data /var/www/html/var/log",
"chown -R www-data:www-data /var/www/html/var/cache"
],
I'm happy to report that your changes result in a functioning demo gssp that can be used for registrations and authentications. So big up there 👍
MKodde
requested changes
Jan 29, 2026
Prior to this change, no copy-paste detection was performed as phpcpd was abanodoned. This change installs jscpd and checks the src dir.
The remaining ones are from `compass-mixins`
johanib
force-pushed
the
feature/upgrade
branch
from
e289676 to
e7654bf
Compare
MKodde
requested changes
Feb 5, 2026
| "description": "Example Generic SAML Stepup Provider.", | ||
| "type": "project", | ||
| "minimum-stability": "stable", | ||
| "minimum-stability": "dev", |
| @@ -1,22 +1,24 @@ | |||
| @import "../../node_modules/compass-mixins"; | |||
| @include global-reset ; | |||
| @use "sass:meta"; | |||
Member
There was a problem hiding this comment.
This change causes two build errors that I do not understand right out of the box. Please investigate
┌──> node_modules/compass-mixins/lib/compass/reset/_utilities.scss
116│ #{elements-of-type(html5-block)} {
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Thanks heaps for fixing the bulk of the deprecation warnings by the way 🐈⬛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.