Open
Conversation
MKodde
force-pushed
the
maintenance/add-sqlite-to-openconext-phpfpm-dev
branch
from
1d94523 to
cc9bd99
Compare
MKodde
force-pushed
the
maintenance/add-sqlite-to-openconext-phpfpm-dev
branch
from
cc9bd99 to
f6551f5
Compare
Contributor
|
Where is the test located that uses this? If it uses Docker, a Docker mySQL image should be trivial to use, which also creates a situation that looks more like what is used on production |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sqlite is required to run certain db integration tests. Having a MySQL database in a test env often proves to be overkill so we opted for a lightweight SQLite solution in the User Lifecycle project. The SQLite PHP extension was already compiled into the Alpine PHP image. But SQLite itself had to be installed