Conversation
MKodde
force-pushed
the
feature/ssp-test-sp
branch
2 times, most recently
from
b30dcdb to
65658e4
Compare
docker/ssp-debug-sp/Dockerfile
Outdated
| # Install Composer | ||
| COPY --from=composer /usr/bin/composer /usr/local/bin/composer | ||
|
|
||
| # Fix npm |
There was a problem hiding this comment.
NPM is not installed. Do you really need these steps?
| # Install SSP: Clone and install rev adf1eb8 of SSP | ||
| WORKDIR /var/simplesamlphp/ | ||
| RUN git clone https://github.com/simplesamlphp/simplesamlphp.git /var/simplesamlphp | ||
| RUN git reset --hard adf1eb8 |
There was a problem hiding this comment.
Why the --hard reset here? And not a tag or a version?
There was a problem hiding this comment.
Good point, I want to install this specific revision as it is also used in the Stepup-deploy SSP task. Using gir reset works for me in that respect.
As a step forward for this, I'd like to go to a more recent SSP version. But we might not be compatible with those versions yet. Given we use some older SSP constructions in the debug sp module.
| @@ -0,0 +1,42 @@ | |||
| FROM webdevops/php-nginx:7.2 AS ssp-debug-sp | |||
There was a problem hiding this comment.
Why the "ancient" 7.2 and not 8.1 ?
There was a problem hiding this comment.
Good point, and I tested if we could use a more recent version. But the currently installed SSP version restricts us to using a 7.2 PHP.
MKodde
force-pushed
the
feature/ssp-test-sp
branch
8 times, most recently
from
e3b4f2d to
4b5d0e6
Compare
MKodde
force-pushed
the
feature/ssp-test-sp
branch
4 times, most recently
from
6303bcd to
e24e14c
Compare
MKodde
force-pushed
the
feature/ssp-test-sp
branch
3 times, most recently
from
e295c3b to
a299d29
Compare
MKodde
force-pushed
the
feature/ssp-test-sp
branch
from
a299d29 to
e9e1452
Compare
2 participants
No description provided.