Skip to content

Added ratelimit headers as class properties #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions opencage/geocoder.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import requests
import backoff
from .version import __version__
from datetime import datetime

try:
import aiohttp
Expand Down Expand Up @@ -130,6 +131,9 @@ class OpenCageGeocode:
"""

session = None
ratelimit_limit = None
ratelimit_remaining = None
ratelimit_reset = None

def __init__(self, key, protocol='https', domain=DEFAULT_DOMAIN, sslcontext=None):
"""Constructor."""
Expand Down Expand Up @@ -262,6 +266,26 @@ def _opencage_request(self, params):
else:
response = requests.get(self.url, params=params, headers=self._opencage_headers('requests')) # pylint: disable=missing-timeout

headers_keys = {
'ratelimit_limit': {
'header': 'x-ratelimit-limit',
'conversor': lambda v: int(v) if v else self.ratelimit_limit
},
'ratelimit_remaining': {
'header': 'x-ratelimit-remaining',
'conversor': lambda v: int(v) if v else self.ratelimit_remaining
},
'ratelimit_reset': {
'header': 'x-ratelimit-reset',
'conversor': lambda v: datetime.fromtimestamp(int(v)) if v else self.ratelimit_reset
}
}

for prop_name, prop_data in headers_keys.items():
header_value = response.headers.get(prop_data['header'])
conversor = prop_data['conversor']
setattr(self, prop_name, conversor(header_value))

try:
response_json = response.json()
except ValueError as excinfo:
Expand Down
45 changes: 45 additions & 0 deletions test/test_ratelimit_properties.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
# encoding: utf-8
from datetime import datetime
from pathlib import Path
import os
import httpretty
from httpretty import httprettified
from opencage.geocoder import OpenCageGeocode

# reduce maximum backoff retry time from 120s to 1s
os.environ['BACKOFF_MAX_TIME'] = '1'

geocoder = OpenCageGeocode('abcde')


@httprettified
def test_rate_limit_properties_no_headers():
httpretty.register_uri(
httpretty.GET,
geocoder.url,
body=Path('test/fixtures/uk_postcode.json').read_text(encoding="utf-8")
)
_ = geocoder.geocode("EC1M 5RF")

assert geocoder.ratelimit_limit is None
assert geocoder.ratelimit_remaining is None
assert geocoder.ratelimit_reset is None


@httprettified
def test_rate_limit_properties():
httpretty.register_uri(
httpretty.GET,
geocoder.url,
body=Path('test/fixtures/uk_postcode.json').read_text(encoding="utf-8"),
adding_headers={
'X-RateLimit-Limit': '2500',
'X-RateLimit-Remaining': '2487',
'X-RateLimit-Reset': '1402185600'
}
)
_ = geocoder.geocode("EC1M 5RF")

assert geocoder.ratelimit_limit == 2500
assert geocoder.ratelimit_remaining == 2487
assert geocoder.ratelimit_reset == datetime.fromtimestamp(1402185600)