Skip to content

Fix for datasetmanager tests #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2025
Merged

Fix for datasetmanager tests #578

merged 3 commits into from
Jul 4, 2025

Conversation

Aserhisham
Copy link
Collaborator

Used group so that the tests would be serialized instead of parallel and used mock directories instead of the test folder

objects instead of real datasets and used group
to avoid race conditions in tests
@coveralls
Copy link
Collaborator

coveralls commented Jun 22, 2025

Pull Request Test Coverage Report for Build 15931015815

Details

  • 127 of 133 (95.49%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 92.068%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/test_dataset.py 127 133 95.49%
Totals Coverage Status
Change from base Build 14959536014: -0.02%
Covered Lines: 8253
Relevant Lines: 8964

💛 - Coveralls

@Aserhisham Aserhisham linked an issue Jun 26, 2025 that may be closed by this pull request
Copy link
Member

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't completely understand the logic, but it seems to work, so fine from my side.

@Aserhisham Aserhisham merged commit 9c2c22f into main Jul 4, 2025
5 checks passed
@Aserhisham Aserhisham deleted the race-conditions branch July 4, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datasetmanager tests race condition
3 participants