Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release and update documentation #554

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Jan 19, 2025

  • Update GitHub Actions workflow for documentation: Don't set pre-releases as stable
  • Modify pyproject.toml for release adjustments

- Update GitHub Actions workflow for documentation
- Modify pyproject.toml for release adjustments
@rettigl
Copy link
Member Author

rettigl commented Jan 19, 2025

@zain-sohail With this docs built for pre-releases (aN suffix) will not be tagged as "stable". Also, python versions will be correctly tagged now with the new build system

@rettigl rettigl requested a review from zain-sohail January 19, 2025 21:22
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12857271066

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.167%

Totals Coverage Status
Change from base Build 12811246523: 0.0%
Covered Lines: 7695
Relevant Lines: 8349

💛 - Coveralls

Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the action works. Any reason why you merge to v1?

@rettigl
Copy link
Member Author

rettigl commented Jan 20, 2025

Any reason why you merge to v1?

The changes to pyproject would require additional merges probably, and we want to merge v1 anyways...

@rettigl rettigl merged commit 975a506 into v1_feature_branch Jan 20, 2025
6 checks passed
@rettigl rettigl deleted the fix-release-and-docs branch January 20, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants