Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mpes elab metadata #551

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Mpes elab metadata #551

wants to merge 19 commits into from

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Jan 14, 2025

This PR adds metadata retrieval from elabFTW at fhi.

Base automatically changed from flash-metadata-fixes to v1_feature_branch January 15, 2025 23:28
@rettigl rettigl force-pushed the mpes_elab_metadata branch 2 times, most recently from e08911f to 8d969e0 Compare January 16, 2025 14:39
@coveralls
Copy link
Collaborator

coveralls commented Jan 16, 2025

Pull Request Test Coverage Report for Build 13641008901

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 280 of 309 (90.61%) changed or added relevant lines in 5 files are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 92.444%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sed/loader/mpes/loader.py 6 7 85.71%
src/sed/loader/mpes/metadata.py 159 187 85.03%
Files with Coverage Reduction New Missed Lines %
src/sed/core/processor.py 10 85.64%
Totals Coverage Status
Change from base Build 13167417292: 0.3%
Covered Lines: 8161
Relevant Lines: 8828

💛 - Coveralls

@zain-sohail zain-sohail self-requested a review January 16, 2025 15:14
@zain-sohail
Copy link
Member

Hard for me to test this without any access. But I notice tests missing. Rather up to you if you'd like to include them or have done rough integration tests already.

@rettigl rettigl force-pushed the mpes_elab_metadata branch from d84d0ea to ac18011 Compare January 16, 2025 15:43
@rettigl
Copy link
Member Author

rettigl commented Jan 16, 2025

Hard for me to test this without any access. But I notice tests missing. Rather up to you if you'd like to include them or have done rough integration tests already.

This is a draft so far. I will include tests eventually

@rettigl rettigl mentioned this pull request Feb 4, 2025
12 tasks
@rettigl rettigl changed the base branch from v1_feature_branch to main February 5, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants