-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html representation of processor and metadata in notebooks #395
Conversation
Similar additions were attempted in #305 but those are more specific to loaders with runs and maybe to Flash. We can see how to include those. |
Pull Request Test Coverage Report for Build 8987621591Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally like this a lot, however computing the head takes quite some time apparently, making the output quite slow.
Maybe we should discuss which parts of the beamtime addition to the representation we want to add.
Also, we should have tests for this as well (to see that it runs correctly for the different loaders, without a dataframe loaded, etc.).
The problem has been resolved. It was the |
I have added tests to the Metadata class and it's repr/repr_html but not sure how to test what you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
We can still add part of Steinn's code, or do this in a later PR (add issue then).
This PR introduces an expandable representation of the data and metadata, and perhaps plots. We can discuss what should be included and what not.
Just type
sp
in a notebook after processor class has been instantiated and it will output the html version.But also the metadata repr is interesting:
To test: you can write
sp.attributes
in a notebook and that will give the html representation.If
print(sp.attributes)
is used, it gives a yaml representation, which is also more human readable than json.closes #35