refactor/(bankconnectors): Extract correlationId from CallContext bef…#2686
Merged
simonredfern merged 2 commits intoOpenBankProject:developfrom Feb 10, 2026
Merged
refactor/(bankconnectors): Extract correlationId from CallContext bef…#2686simonredfern merged 2 commits intoOpenBankProject:developfrom
simonredfern merged 2 commits intoOpenBankProject:developfrom
Conversation
…ore async operations - Extract correlationId from CallContext arguments before entering Future callbacks to ensure availability in async contexts - Move correlationId extraction to the beginning of invokeMethod, outside of Future scopes where Lift's S.containerSession is unavailable - Remove duplicate TODO comments about correlation_id handling in connector metrics - Implement fallback to getCorrelationId() when no CallContext is present in arguments - Consolidate correlationId retrieval logic to a single location for better maintainability - Fixes issue where correlation_id was unreliable in async metric recording due to Lift session unavailability
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ore async operations