-
Notifications
You must be signed in to change notification settings - Fork 117
[frontend/backend] chunk 1 scenario assistant #3225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Marine LM <[email protected]>
Signed-off-by: Marine LM <[email protected]>
Signed-off-by: Marine LM <[email protected]>
Signed-off-by: Marine LM <[email protected]>
Signed-off-by: Marine LM <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/current #3225 +/- ##
=====================================================
+ Coverage 42.07% 42.74% +0.66%
- Complexity 2469 2542 +73
=====================================================
Files 704 705 +1
Lines 21781 22173 +392
Branches 1481 1538 +57
=====================================================
+ Hits 9165 9478 +313
- Misses 12112 12181 +69
- Partials 504 514 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openbas-front/src/admin/components/scenarios/scenario/ScenarioAssistantDrawer.tsx
Outdated
Show resolved
Hide resolved
Tested : Ok (multiplatforme, multiTTP) |
Signed-off-by: Marine LM <[email protected]>
Signed-off-by: Marine LM <[email protected]>
Signed-off-by: Marine LM <[email protected]>
|
||
@PersistenceContext private EntityManager entityManager; | ||
|
||
public List<Inject> generateInjectsForScenario(Scenario scenario, InjectAssistantInput input) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick (non-blocker) : Javadoc on top of the public methods (or even better on the private methods too) would be nice
manualInjectorContract, | ||
String.format( | ||
"[%s] Placeholder - %s %s", attackPattern.getExternalId(), platform, architecture), | ||
String.format( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question : Does that mean every title of injects are in english if generated by AI ? If so, might need to be validated by product
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've replicated the same behavior as the injects generated by openCTI.
But sure, i will confirm that with the product
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I feel that's a more global issue : some stuff on our backend is not localized and it might end up being a problem at some point ...
openbas-api/src/main/java/io/openbas/rest/inject/service/InjectAssistantService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Marine LM <[email protected]>
Seems to be working but I might have a dumb question. If I invoke the scenario assistant multiple times, it always add new injects. Is it expected or should it take into account what's already in the scenario ? |
Signed-off-by: Marine LM <[email protected]>
Proposed changes
Front
Back
Related issues