Skip to content

[frontend] add active & executors columns to assets selection in inje… #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: release/current
Choose a base branch
from

Conversation

guillaumejparis
Copy link
Member

…ct form (#3219)

Proposed changes

Testing Instructions

  1. Step-by-step how to test
  2. Environment or config notes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@guillaumejparis guillaumejparis linked an issue May 21, 2025 that may be closed by this pull request
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.58%. Comparing base (3db8a09) to head (9c43d82).
Report is 3 commits behind head on release/current.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #3221      +/-   ##
=====================================================
- Coverage              42.79%   42.58%   -0.22%     
- Complexity              2532     2553      +21     
=====================================================
  Files                    705      710       +5     
  Lines                  22000    22396     +396     
  Branches                1500     1560      +60     
=====================================================
+ Hits                    9415     9537     +122     
- Misses                 12071    12341     +270     
- Partials                 514      518       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damgouj damgouj self-requested a review May 26, 2025 07:00
Copy link
Member

@damgouj damgouj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and problem detected:
image

  • When I want to add an asset on my inject for the first time, the executors are unknown instead of having the icons.
  • I know we haven't the headers for this table but I am not sure we understand what is the column "executors" for ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve assets selection in inject creation/update
2 participants