-
Notifications
You must be signed in to change notification settings - Fork 117
[backend] Define a logic for saving structured outputs #3162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/current
Are you sure you want to change the base?
Conversation
64a939c
to
e792c56
Compare
36da149
to
e922925
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/current #3162 +/- ##
=====================================================
+ Coverage 42.27% 42.41% +0.14%
- Complexity 2484 2505 +21
=====================================================
Files 704 707 +3
Lines 21800 21843 +43
Branches 1483 1497 +14
=====================================================
+ Hits 9215 9265 +50
+ Misses 12077 12064 -13
- Partials 508 514 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openbas-model/src/main/java/io/openbas/database/model/ExecutionTrace.java
Outdated
Show resolved
Hide resolved
openbas-api/src/main/java/io/openbas/rest/inject/service/InjectExecutionService.java
Outdated
Show resolved
Hide resolved
openbas-api/src/main/java/io/openbas/rest/inject/service/InjectExecutionService.java
Outdated
Show resolved
Hide resolved
openbas-model/src/main/java/io/openbas/database/model/ExecutionTrace.java
Outdated
Show resolved
Hide resolved
Test : ok |
To help understand what is done in this PR and improve readability, do you think you could add more comments and/or javadocs ? |
Still OK with the PR but I'm wondering if we should merge it now or after the next release
Proposed changes
Testing Instructions
Create a payload with a output parser

Exemple PortScan: (TCP|UDP)\s+([\d.[]:]+):(\d+)\s+([\d.[]:]+):(\d+|*)\s+(\S+) {host:$2, port: $3, service: $6}
Execute an inject with this paylaod
Verify in DDBB if there is any trace with a value in the column: structured_message (with the output parser structure)

If you have enabled findings, verify if any find was created
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...