Cache the DetectableDB scan results #123
Open
+77
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by a performance problem rightfully pointed out in PR #92, I set out to greatly optimize the process scan:
main
main
, simply no GC spikes happened hereThe change works on my end, but is also provably correct (assuming
DetectableDB
does not change) because:DetectableDB
's contents,args
, andtoCompare
toCompare
is derived fromsplitPath
splitPath
is derived frompath
Notes:
await Native.getProcesses();
. Improve linux game detection #92 does add functionality to this call but the performance difference is negligible (16.3ms -> 18.3ms, possibly within margin of error)DetectableDB
.Open questions:
DetectableDB
entries being detected with one process is intentional, but I cache an array of all detected entries to keep this behavior