fix: undetected games when ran with administrator #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
Windows built-in tools such as wmic or gcim or gwmi doesn't have enough privilege even if those tools were running with administrator. Consequently, the game isn't detected due to the empty result when querying executable path.
Solution
This fix uses windows undocumented api calls
NtQuerySystemInformation()
to get the ImageFileName of a process by supplying pid into the api. It useskoffi
package to load those windows libraries.Result
As a result, it can detect games that ran with administrator without the need to run arrpc with administrator.
This might also fix #33
Remark
The usage of NtQuerySystemInformation() may be altered or unavailable in future versions of Windows