[JAVA] [SPRING] Handle list of String special case in reactive generator#24078
Draft
TMRGZ wants to merge 2 commits into
Draft
[JAVA] [SPRING] Handle list of String special case in reactive generator#24078TMRGZ wants to merge 2 commits into
TMRGZ wants to merge 2 commits into
Conversation
Author
|
The Kotlin Spring generator could need a similar fix but I am not used to code in Kotlin, feel free to add it to this PR |
Contributor
|
I only reviewed on mobile so far, but do I understand correctly that you are hiding the 'now correct' behavior behind a config option and by default it will still produce the incorrect code? I would expect it to be either
As I mentioned this is based on a very quick skimming of the changes in the PR. Note: I am not in any way a maintainer of this project - just providing my proverbial 2 cents of feedback (-: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #24077
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Fixes reactive Spring return types for array of string responses by returning Mono<List> or Mono<Set> instead of Flux. Applies to
spring-bootandspring-http-interfacelibraries and aligns generated code with the OpenAPI schema.x-reactive-return-except-list-of-stringvendor extension.SpringCodegensets the extension for array responses with base typestringin reactive mode.responseType.mustacheto emitMono<ResponseEntity<List<String>>>/Mono<ResponseEntity<Set<String>>>(or withoutResponseEntity) instead ofFlux<String>.spring-bootandspring-http-interface, with and withoutuseResponseEntity, verifyingMono<List<String>>/Mono<Set<String>>signatures.Written for commit b07ba00. Summary will update on new commits.