Skip to content

Conversation

@rgroothuijsen
Copy link
Contributor

@rgroothuijsen rgroothuijsen commented Jan 30, 2026

The JSON.stringify replacer function defines two parameters, though only one is currently used. Since the Typescript compiler may throw errors depending on configured strictness, an annotation has been added to ignore the unused parameter. Purely for correctness, the type of the key parameter was also fixed to string in accordance with the original interface definition.

Fixes #22798

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Suppresses TypeScript strict-mode errors in the typescript-axios JSON.stringify replacer and corrects the parameter type to match the official signature. No runtime changes. Fixes #22798.

  • Bug Fixes
    • Add // @ts-ignore to ignore the unused key parameter in the replacer.
    • Change replacer signature from (key: any) to (key: string).
    • Update the generator template and regenerate affected samples.

Written for commit 54f9e75. Summary will update on new commits.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 16 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Typescript typecheck issue with generated axios code

1 participant