Skip to content

Conversation

sruehl
Copy link
Contributor

@sruehl sruehl commented Sep 4, 2025

Closes #21895

As defined in #21895 this will add a option to prefix the enums constants with a type a test that proofs that inline enums in combination with enumClassPrefix is actually already doing the right thing

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@sruehl
Copy link
Contributor Author

sruehl commented Sep 4, 2025

FYI: @antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5 working on a fix to solve the enum collision issue

@sruehl
Copy link
Contributor Author

sruehl commented Sep 4, 2025

seems like enumClassPrefix is doing that exactly.... Will update this PR only with the test at the end it seems.

@sruehl sruehl force-pushed the feat/enum_type_prefixing branch from 0dc1ce6 to 658bd13 Compare September 4, 2025 12:24
@sruehl sruehl changed the title feat(golang): Prefix enum option to dodge other enums. test(golang): proof that enums can be dodged Sep 4, 2025
@sruehl
Copy link
Contributor Author

sruehl commented Sep 4, 2025

Edit: Classical user error. The option enumClassPrefix with the inline schema option RESOLVE_INLINE_ENUMS is already doing everything

@sruehl sruehl marked this pull request as ready for review September 4, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Golang] Enum names collide
1 participant