-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update the readthedocs integration for PRs in this repo #65
Conversation
Should we open PR to track that migration? |
I think keeping apps related docs in system-reference will be more helpful. Then openamp-docs can point link to this repo. But I am open to otherway as well. |
I would be in favor of having complex documentation (for instance, PNG schematics) in the openamp-docs repo and just a README in the system-reference demo explaining how to build and run the demo. And regarding @sipke's work on documentation, we probably have some duplications that should be cleaned up in the openamp-docs repo. |
open-amp issue is here: OpenAMP/open-amp#638 |
Based on the discussion at OpenAMP system reference meeting on Feb 19th, we don't expect the doc/ directory in this repo to contain anything. I don't think we should create it just for this one file. I suggest I rework this PR to move the doc/readthedocs_conf.py file to /.readthedocs_conf.py (in the root dir and with a leading dot) @arnopo when you get back from vacation let me know if you agree |
@arnopo I have moved the config doc to the root dir (with a leading . ) and I don't create the doc dir. |
Upstream Read The Docs has tightened up the schema checking and this broke what we were doing for PRs. A good number of things were tried but the best compromise is to: * supply a dummy sphinx config file in this repo * as this repo does not have a doc/ dir we put the file in the root * override the default build command to use the openamp-docs dir Also: * add more documentation about what is going on * lock to html only format. PRs only do html anyway but make sure Signed-off-by: Bill Mills <[email protected]>
I pushed again to add the leading . in the print statement: |
Upstream Read The Docs has tightened up the schema checking and this broke what we were doing for PRs.
A good number of things were tried but the best compromise is to:
Also: