Bring in Xilinx-AMD commits #64
Conversation
Move all app configuration variables to platform_info.h so that all the relevant information that can be configured is in one file. This makes the application easier to configure and debug. Signed-off-by: Ben Levinsky <[email protected]>
bentheredonethat
force-pushed
the
amd-main-jan9-2025
branch
from
30aa6c0 to
ff612ef
Compare
|
@arnopo i have updated as follows
hopefully this will make it easier for you to review! |
bentheredonethat
force-pushed
the
amd-main-jan9-2025
branch
from
ff612ef to
8cab9c3
Compare
|
Squash this commit: apps: rpmsg-echo: poll on vdev reset flag into this one apps: platform_info: add API for vdev reset flag |
when remote processor is detached or stopped by host, it sets vdev reset flag to 0 via virtio config ops in resource table. Introduce API that will poll on this flag to destroy endpoints and virtio devices. Application should re-create rpmsg devices once coming out of loop from this function, so host can re-attach to this Also use new API platform_poll_on_vdev_reset to poll interrupts from host instead of platform_poll Signed-off-by: Tanmay Shah <[email protected]> Signed-off-by: Ben Levinsky <[email protected]>
1. Enable CMake build to pass in linker flags. This will enable Xilinx-AMD
System Device Tree Flow BSP-based tooling to pass required linker
flags
2. Enable System Device Flow compliant linker script where many sections
are placed in DDR for space and entry point provided by BSP is
_vector_table instead of _boot
3. Ensure symbols are present for both classic and System Device Flow flow
for each of the above SOC's.
4. Remove symbols that are also present in BSP
5. Add Versal NET SDT Linker script
Signed-off-by: Ben Levinsky <[email protected]>
…lugin As System Device Tree flow supports Lopper generated OpenAMP Linker scripts enable the configuration of these for ZynqMP, Versal and Versal-NET SOC's. Signed-off-by: Ben Levinsky <[email protected]>
Signed-off-by: Ben Levinsky <[email protected]>
bentheredonethat
force-pushed
the
amd-main-jan9-2025
branch
from
8cab9c3 to
5227f8a
Compare
done |
| @@ -115,23 +106,43 @@ int main(int argc, char *argv[]) | |||
| ret = platform_init(argc, argv, &platform); | |||
| if (ret) { | |||
| LPERROR("Failed to initialize platform.\r\n"); | |||
| ret = -1; | |||
| } else { | |||
| ML_ERR("Server reboot is required to recover\r\n"); | |||
There was a problem hiding this comment.
This commit does not build du to ML_ERR
this messgae seems related to the test environment not the example. I would remove it and
There was a problem hiding this comment.
seems like this comment cut out. what are you asking for here?
i can move the ML_* commit to first if that helps.
There was a problem hiding this comment.
One of the criteria for a PR is that we are able to build the openamp lib, regardless of the commit we point to in the PR.
the build fails pointing on 70598c4
There was a problem hiding this comment.
@bentheredonethat just replace all the ML_* macros with metal_* macros from first PR. If it's already resolved, ignore this comment and resolve this conversation.
| * Server behavior is undefined. It's better to wait in | ||
| * an infinite loop instead | ||
| */ | ||
| while (1); |
There was a problem hiding this comment.
Here you will break the CI that should migrate on these examples. This should be addressed in your test environment
There was a problem hiding this comment.
see tanmay's comment
| * Server behavior is undefined. It's better to wait in | ||
| * an infinite loop instead | ||
| */ | ||
| while (1); |
There was a problem hiding this comment.
@arnopo is that okay, if we can define return of main based on PROJECT_SYSTEM variable ?
#ifdef PROJECT_SYSTEM == LINUX
return ;
#else
while (1);
#endif
There was a problem hiding this comment.
That seems to me not enough generic.
Behavior is platform dependent so I would be treated in platform_info.c , what about implementing in cleanup_system or a system_shutdown that would be empty by default?
There was a problem hiding this comment.
Yes that's a good idea. It will be re-factored accordingly.
Bring in commits from Xilinx-AMD fork of OpenAMP System Reference Repo.