This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Add EEPROM encapsulation #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on#6) Add LiquidCrystal_TC stub class and devices directory.
jgfoster
reviewed
Nov 2, 2020
src/Devices/EEPROM_TC.cpp
Outdated
| } | ||
|
|
||
| double EEPROM_TC::readTempSetPoint() { | ||
| // Load from EEPROM |
There was a problem hiding this comment.
double value = readDouble(TEMP_ADDRESS);
if (isnan(value)) {
return 20;
}
return value;
}
jgfoster
reviewed
Nov 2, 2020
| void doubleWrite(int address, double value); | ||
| double doubleRead(int address); | ||
|
|
||
| private: |
There was a problem hiding this comment.
add private methods for read/write double.
added 4 commits
November 4, 2020 21:51
|
We can review this after Arduino-CI/arduino_ci#184 and Arduino-CI/arduino_ci#198 are merged. They should resolve the size cast warnings. |
|
@all-contributors please add @Lizj96 for code |
|
I've put up a pull request to add @Lizj96! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.